Closed
Conversation
github-actions
Bot
added
the
Libraries: Out of sync
astrojuanlu
force-pushed
the
juanlu/separation-storage
branch
from
4c19f98 to
a7f08e2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
astrojuanlu
force-pushed
the
juanlu/separation-storage
branch
from
a7f08e2 to
acdca83
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
astrojuanlu
force-pushed
the
juanlu/separation-storage
branch
6 times, most recently
from
f1d9e89 to
905bf25
Compare
astrojuanlu
changed the title
Contributor
Author
|
I'm keeping an eye on some of the trickiest integration tests but this is ready for a first pass. |
astrojuanlu
force-pushed
the
juanlu/separation-storage
branch
2 times, most recently
from
99a398c to
32eef11
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
astrojuanlu
force-pushed
the
juanlu/separation-storage
branch
from
32eef11 to
eaab6c3
Compare
Contributor
sinclert-canonical
left a comment
sinclert-canonical
left a comment
There was a problem hiding this comment.
LGTM overall. Left a bunch of comments.
astrojuanlu
force-pushed
the
juanlu/separation-storage
branch
2 times, most recently
from
290e489 to
9c9549b
Compare
Contributor
Author
|
I hope the last push fixes a bogus test, I think the rest is flakiness. |
Contributor
sinclert-canonical
left a comment
sinclert-canonical
left a comment
There was a problem hiding this comment.
Provided 2nd round of reviews. Waiting for clarification in a couple of threads.
2 tasks
astrojuanlu
force-pushed
the
juanlu/separation-storage
branch
from
a921ee4 to
25a6bd9
Compare
astrojuanlu
force-pushed
the
juanlu/separation-storage
branch
from
25a6bd9 to
2bf93fe
Compare
paulomach
reviewed
Apr 17, 2026
Contributor
paulomach
left a comment
paulomach
left a comment
There was a problem hiding this comment.
Quick pass. Should we ensure all mount points are mounted before do we initialization?
Imagine a case where archive is not mounted a we start logging to the directory, instead of the mounted device
paulomach
reviewed
Apr 17, 2026
| type: filesystem | ||
| description: Persistent storage for data | ||
| location: /var/snap/charmed-mysql/common | ||
| description: Persistent storage for MySQL data |
Contributor
There was a problem hiding this comment.
Same as k8s
Suggested change
| description: Persistent storage for MySQL data | |
| description: Persistent storage for MySQL error logs, general query logs, slow query logs, binary logs, redo logs and undo logs |
paulomach
approved these changes
Apr 17, 2026
Contributor
paulomach
left a comment
paulomach
left a comment
There was a problem hiding this comment.
Looks good - Check open comments - Thanks!!!
astrojuanlu
force-pushed
the
juanlu/separation-storage
branch
from
a503c0d to
edcf10f
Compare
2 tasks
Contributor
Author
|
I know this one is approved but
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Solution
Checklist